vz: remove spice #1261
Merged
vz: remove spice #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajiv113
reviewed
Dec 23, 2022
pkg/vz/vm_darwin.go
Outdated
|
|
||
| func attachConsole(_ *driver.BaseDriver, vmConfig *vz.VirtualMachineConfiguration) error { | ||
| consoleDevice, err := vz.NewVirtioConsoleDeviceConfiguration() | ||
| if err != nil { |
Member
There was a problem hiding this comment.
i think we can remove the entire attachConsole method itself
We can re-add this when we provide support for display.
Member
Author
There was a problem hiding this comment.
Potentially something may not work when no console is connected?
Member
There was a problem hiding this comment.
It should be fine as far as i know. Not all configs are mandatory / required to be set.
Member
Author
There was a problem hiding this comment.
removed the entire console
AkihiroSuda
force-pushed
the
vz-remove-spice
branch
from
61041e7 to
f48d6b3
Compare
balajiv113
previously approved these changes
Dec 23, 2022
Fix issue 1260 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
vz-remove-spice
branch
from
f48d6b3 to
c437a9d
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1260