Hide columns in the list command

[afbjorklund]

• Hide identical columns in the list command

  If all the instances have the same type or arch,
  then don't display the column - unless requested.

• Hide the directory column on narrow terminal

  If the terminal width does not fit all the list
  columns, then hide "dir" column - unless requested.

before

NAME    STATUS     SSH            VMTYPE    ARCH      CPUS    MEMORY    DISK   
   DIR
k8s     Stopped    127.0.0.1:0    qemu      x86_64    4       4GiB      100GiB  
  ~/.lima/k8s

after

NAME    STATUS     SSH            CPUS    MEMORY    DISK      DIR
k8s     Stopped    127.0.0.1:0    4       4GiB      100GiB    ~/.lima/k8s

NAME    STATUS     SSH            VMTYPE    ARCH      CPUS    MEMORY    DISK
k8s     Stopped    127.0.0.1:0    qemu      x86_64    4       4GiB      100GiB

One can use the --all-fields flag, to get the old behaviour back again.

On a wide enough terminal, the table output is the same as before.

Closes #1204

[AkihiroSuda]

Thanks, but needs rebase

[AkihiroSuda]

Found a regression: The ARCH field is no longer printed even when the terminal width is enough.

LGTM other than that.

[AkihiroSuda]

I'd also like to see unit tests

[afbjorklund]

Found a regression: The ARCH field is no longer printed even when the terminal width is enough.

No regression, it was separate features. But we can make the arch/type dedup depend on width too ?

[jandubois]

Found a regression: The ARCH field is no longer printed even when the terminal width is enough.

I think I'm find with the ARCH field being removed, even when there is enough space, as long as all machines use the native arch:

hideArch = len(archs) == 1 && archs[0] == runtime.GOARCH

I don't think it adds any value in that situation, which I expect is going to be rather common.

[AkihiroSuda]

Lints are failing

[afbjorklund]

Lints are failing

Needed to upgrade my golangci-lint

[afbjorklund]

I don't think it adds any value in that situation

I never found any value from the SSH column, but maybe it has some ?

Especially the 127.0.0.1:0 is weird, but also others.

You need to use show-ssh anyway, to get something actually usable.

But we can hide the arch and vmtype again, sure.

[jandubois]

Especially the 127.0.0.1:0 is weird, but also others.

I agree, but maybe we should leave this for future discussion / another PR, so we can get this change wrapped up and merged?

[afbjorklund]

Ok, so let's autohide again and see how that goes.

[jandubois]

Always hide identical columns any width

That's not what we agreed on, we agreed to auto-hide the ARCH column if all values are identical to the local arch.

I thought that was the only remaining change, and that's why I didn't want to open the discussion to include the SSH column as well.

[afbjorklund]

Just that it always shows the vm type, even if there is only one vm type (on Linux)

[AkihiroSuda]

Thanks

[AkihiroSuda]

Sorry needs rebase

[jandubois]

ARCH should only be hidden when all instances use the host arch.

[afbjorklund]

Did the rebase and the simple edits, others are left todo.

[AkihiroSuda]

Did the rebase and the simple edits, others are left todo.

Should this PR be marked as a draft?

[AkihiroSuda]

Thanks

[AkihiroSuda]

@jandubois LGTY?

[jandubois]

Thanks, LGTM!