-
Notifications
You must be signed in to change notification settings - Fork 768
Add progress option for showing progress only #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The first commit is from #1308, it messes up the progress bar to have both that and the log at the same time. |
|
Fixed the width, when not keeping the output but cleaning the progress bar. Haven't yet fully decided, which option is the best - there are pros and cons... |
cmd/limactl/start.go
Outdated
| startCommand.Flags().Bool("tty", isatty.IsTerminal(os.Stdout.Fd()), "enable TUI interactions such as opening an editor, defaults to true when stdout is a terminal") | ||
| startCommand.Flags().String("name", "", "override the instance name") | ||
| startCommand.Flags().String("set", "", "modify the template inplace, using yq syntax") | ||
| startCommand.Flags().Bool("progress", false, "show progress") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing, because the progress is shown in the default mode.
What about taking a ternary value (auto|true|false)?
e.g., limactl (default) implies --progress=true, and limactl --log-level=warn implies --progress=false.
For your usecase you might want to use limactl --log-level=warn --progress=true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be split
e0c8c7d to
bdf9650
Compare
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
After hiding the INFO messages, enable some progress.
Starting "default"READY.Showing the requirements as a progress bar, using
pb.Closes #1311