Add builtin yq support to limactl edit command

[afbjorklund]

Also add --tty parameter, similar to the start command, for avoiding user interaction asking whether to start it.

$ limactl edit --tty=false --set ".cpus = 2" default
INFO[0000] Instance "default" configuration edited      
$ limactl edit --tty=false --set ".cpus = 2" default
INFO[0000] Aborting, no changes made to the instance  

Follow-up to:

• Add builtin yq support to lima start command #1359

[jandubois]

I think limactl edit --set ... should not invoke the editor. I can't think of any situation where I want to set some settings via --set, but also want to use the editor as well; I would simply not bother writing the --set options in the first place.

If you ever wanted to do both (which I believe would be extremely uncommon, but maybe from a script), you could still call the command twice:

limactl edit --tty=false --set ".cpus = 3" default
limactl edit default

Even when --set is specified, we should use the --tty setting to determine if we should ask to start the instance or not.

[afbjorklund]

Hmm, for start we open the editor after --set ? That was the behaviour that was copied here.

The --tty should already affect the start prompt.

[jandubois]

for start we open the editor after --set ?

No, we don't. We ask if the user wants to edit the YAML file. But I see the point that maybe that shouldn't happen either. But that should be a separate issue.

For edit we always open the editor right away (because that is the point of the command), so it is more jarring that I have to close the editor again even if I didn't want to open it (because I used --set). And if I specify --tty=false to prevent it, then it won't ask me to start the VM, and I have to start it manually as well.

[jandubois]

Works as expected now (doesn't invoke editor when using --set), but is not showing the lima.yaml content in the editor anymore.

[jandubois]

Thanks, LGTM