-
Notifications
You must be signed in to change notification settings - Fork 768
Rename examples to templates on the git repo
#2809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
Also removes `/usr/local/share/lima/examples` (symlink to `templates`). Follow-up to PR 1679 Fix issue 2808 Signed-off-by: Akihiro Suda <[email protected]>
jandubois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
This "broke" the Lima GUI, in that it will no longer change to the correct directory for you when using the Open... dialog Also the default is gone |
Do you want the symlink to be restored, or do you plan to just update your GUI? |
|
I will update it, it was a bit hardcoded... Probably should look for both of them (for a while, at least) for old Lima. QString examples = getPrefix() + "/share/doc/lima/examples";
QString examples = getPrefix() + "/share/doc/lima/examples";These will just need updating, like any other links to the existing files or hyperlinks. QString defaultYAML()
{
return "examples/default.yaml";
}
QString defaultURL()
{
return "https://github.com/lima-vm/lima/blob/master/examples/default.yaml";
} |
|
You can just use |
|
Right. Then again the class is called Example too :-) So it would probably need some rewriting anyway... The actual examples are hardcoded: https://github.com/afbjorklund/lima-gui/blob/main/examples.cpp |
Also removes
/usr/local/share/lima/examples(symlink totemplates).Follow-up to:
Fix #2808