Skip to content

Conversation

@AkihiroSuda
Copy link
Member

Also removes /usr/local/share/lima/examples (symlink to templates).

Follow-up to:

Fix #2808

Also removes `/usr/local/share/lima/examples` (symlink to `templates`).

Follow-up to PR 1679

Fix issue 2808

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 29e9c93 into lima-vm:master Oct 28, 2024
28 checks passed
@afbjorklund
Copy link
Member

afbjorklund commented Oct 28, 2024

Also removes /usr/local/share/lima/examples (symlink to templates).

This "broke" the Lima GUI, in that it will no longer change to the correct directory for you when using the Open... dialog

Also the default is gone

@AkihiroSuda
Copy link
Member Author

This "broke" the Lima GUI, in that it will no longer change to the correct directory for you when using the Open... dialog

Do you want the symlink to be restored, or do you plan to just update your GUI?

@afbjorklund
Copy link
Member

afbjorklund commented Oct 28, 2024

I will update it, it was a bit hardcoded... Probably should look for both of them (for a while, at least) for old Lima.

    QString examples = getPrefix() + "/share/doc/lima/examples";

    QString examples = getPrefix() + "/share/doc/lima/examples";

These will just need updating, like any other links to the existing files or hyperlinks.

QString defaultYAML()
{
    return "examples/default.yaml";
}

QString defaultURL()
{
    return "https://github.com/lima-vm/lima/blob/master/examples/default.yaml";
}

@AkihiroSuda
Copy link
Member Author

You can just use getPrefix() + /share/doc/lima/templates. This path has been available since #1679 (v0.17.0, Aug 2023).

@afbjorklund
Copy link
Member

afbjorklund commented Oct 28, 2024

Right. Then again the class is called Example too :-) So it would probably need some rewriting anyway...

The actual examples are hardcoded: https://github.com/afbjorklund/lima-gui/blob/main/examples.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git repo: rename examples to templates (will break existing hyperlinks)

3 participants