downloader: simplify tests #2869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Nov 7, 2024
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
LGTM, but needs to fix the YAML lint error (needs 2 spaces before comment on the same line as a value).
Signed-off-by: Oleksandr Redko <[email protected]>
AkihiroSuda
reviewed
Nov 7, 2024
| # https://staticcheck.dev/docs/configuration/options/#checks | ||
| checks: | ||
| - "all" | ||
| - "-SA3000" # false positive for Go 1.15+. See https://github.com/golang/go/issues/34129 |
Member
There was a problem hiding this comment.
Has anybody reported this to staticcheck?
Member
Author
There was a problem hiding this comment.
Yes. It's a bug in golangci-lint and it was fixed yesterday. Will be in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors tests in the
downloaderpackage:os.ExitinTestMain, as of Go 1.15, we do not need to callos.Exit(m.Run())explicitly. See testing: TestMain should not require os.Exit golang/go#34129t.TempDir()instead ofos.MkdirTempbecauseTempDirautomatically removes directory.