-
Notifications
You must be signed in to change notification settings - Fork 707
Add support for collecting instance IP address #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ce812d0
to
7e5a9ee
Compare
Added unconditionally to all editions because in the future Lima will depend on it (it is also part of the default Alpine cloud image). Ref lima-vm/lima#3696 Signed-off-by: Jan Dubois <[email protected]>
7e5a9ee
to
eb07981
Compare
Changes – Draft 2 (edited)gRPC
Hostagent
CLI
Note;
P.S. I'm trying my best to follow the design patterns found in the existing code. If there are any points that need refactoring, please let me know. |
3ba87dc
to
438de9f
Compare
e84ea6a
to
1c9a442
Compare
rpc GetIPv6(google.protobuf.Empty) returns (CommandOutput); | ||
} | ||
|
||
message Info { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that the IP can be added here without wrapping it in CommandOutput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll try adding the IP address directly to RPC and remove all CommandOutput wrapping
1c9a442
to
8ec2ab0
Compare
Edit:
|
Signed-off-by: Songpon Srisawai <[email protected]>
8ec2ab0
to
f9d7c50
Compare
What does this PR do?
instance_info.json
file.Implementation details
With GuestAgent:
ip -j a
is embedded asjson_bytes
in the gRPC Events message.instance_info.json
file.Without GuestAgent (Plain mode):
executeSSH()
function signature to return both the command output and error (instead of just error).executeSSH()
to runip -j a
, processes the output, and writes the instance info locally.Testing
limactl start INSTNAME --network lima:user-v2