Get rid of fetch-depth: 1
#3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is redundant because it is already the default. I suspect that we used it because in many places we needed to specify `fetch-depth: 0` to get all the tags. But with one exception for the colima test, this is no longer the case, so I think we should get rid of all of these. Signed-off-by: Jan Dubois <[email protected]>
afbjorklund
approved these changes
Aug 16, 2025
Member
Author
Shallow clone is already the default. This is a no-op change, just removing the explicit setting of the default value. # Number of commits to fetch. 0 indicates all history for all branches and tags.
# Default: 1
fetch-depth: '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is redundant because it is already the default.
I suspect that we used it because in many places we needed to specify
fetch-depth: 0to get all the tags. But with one exception for the colima test, this is no longer the case, so I think we should get rid of all of these.See also: #3820 (comment)