Skip to content

limactl restart: add --progress #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

limactl restart: add --progress #3915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/limactl/restart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ func newRestartCommand() *cobra.Command {
}

restartCmd.Flags().BoolP("force", "f", false, "Force stop and restart the instance")
restartCmd.Flags().Bool("progress", false, "Show provision script progress by tailing cloud-init logs")
return restartCmd
}

Expand All @@ -40,12 +41,16 @@ func restartAction(cmd *cobra.Command, args []string) error {
if err != nil {
return err
}
progress, err := cmd.Flags().GetBool("progress")
if err != nil {
return err
}

if force {
return instance.RestartForcibly(ctx, inst)
return instance.RestartForcibly(ctx, inst, progress)
}

return instance.Restart(ctx, inst)
return instance.Restart(ctx, inst, progress)
}

func restartBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
Expand Down
5 changes: 2 additions & 3 deletions pkg/instance/restart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ import (

const (
launchHostAgentForeground = false
showProgress = false
)

func Restart(ctx context.Context, inst *limatype.Instance) error {
func Restart(ctx context.Context, inst *limatype.Instance, showProgress bool) error {
if err := StopGracefully(ctx, inst, true); err != nil {
return err
}
Expand All @@ -33,7 +32,7 @@ func Restart(ctx context.Context, inst *limatype.Instance) error {
return nil
}

func RestartForcibly(ctx context.Context, inst *limatype.Instance) error {
func RestartForcibly(ctx context.Context, inst *limatype.Instance, showProgress bool) error {
logrus.Info("Restarting the instance forcibly")
StopForcibly(inst)

Expand Down
Loading