pkg/portfwdserver: Close stream by returning from the handler method
#4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says: https://pkg.go.dev/google.golang.org/grpc#BidiStreamingServer > To terminate the stream, return from the handler method and return an error from the status package, or use nil to indicate an OK status code. - Changed to calling `proxy.HandleConn()`/`bicopy.Bicopy()` as goroutines, then wait `GRPCServerRW.closeCh` in `TunnelServer.Start()` for returning from handler before `HandleConn()`/`bicopy.Bicopy()` finishes. - Added `CloseRead()` and `CloseWrite()` to `GRPCServerRW`. As a result, `GRPCServerRW` may be expected to pass the test added by lima-vm#3708 with inetaf/tcpproxy's `tcpproxy.DialProxy()` or `bicopy.Bicopy()`. Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
fix-closing-grpc-stream-in-guestagent
branch
from
e8887c4 to
34fa305
Compare
It passed https://github.com/lima-vm/lima/actions/runs/18683599851/job/53270327592?pr=4237#step:9:617 |
norio-nomura
commented
Oct 21, 2025
| rw.Close() | ||
| }() | ||
|
|
||
| proxy := tcpproxy.DialProxy{DialContext: func(_ context.Context, _, _ string) (net.Conn, error) { |
|
Thanks!🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says:
https://pkg.go.dev/google.golang.org/grpc#BidiStreamingServer
proxy.HandleConn()/bicopy.Bicopy()as goroutines, then waitGRPCServerRW.closeChinTunnelServer.Start()for returning from handler beforeHandleConn()/bicopy.Bicopy()finishes.CloseRead()andCloseWrite()toGRPCServerRW. As a result,GRPCServerRWmay be expected to pass the test added by CI: test and fix portfwd issue (w3m -dumphangs) #3708 with inetaf/tcpproxy'stcpproxy.DialProxy()orbicopy.Bicopy().