Skip to content

Makefile: native, artifact: include limactl-plugins and additional-drivers #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

Makefile: native, artifact: include limactl-plugins and additional-drivers #4291

merged 1 commit into from
Nov 5, 2025

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 4, 2025 •
edited
Loading

Fix #4289
Fix #4290

make minimal still excludes them

$ make artifacts
$ tar tzvf _artifacts/lima-2.0.0-rc.0-2-g7ec355ea-Darwin-arm64.tar.gz
[...]
drwxr-xr-x  0 suda   staff        0 Nov  5 03:26 ./libexec/lima/
-rwxr-xr-x  0 suda   staff  6479154 Nov  5 03:26 ./libexec/lima/limactl-mcp
-rwxr-xr-x  0 suda   staff 25480194 Nov  5 03:26 ./libexec/lima/lima-driver-krunkit
[...]

lima-driver-krunkit is huge, so rethinking about it ...
Maybe we should split it to lima-additional-drivers package?

@AkihiroSuda
Makefile: native, artifact: include limactl-plugins and additional-dr…
7ec355e 
…ivers

For issue 4289 and issue 4290

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Nov 4, 2025
@AkihiroSuda AkihiroSuda added area/homebrew Homebrew formula area/cli limactl CLI user experience area/vmdrivers VM driver infrastructure labels Nov 4, 2025
@AkihiroSuda AkihiroSuda marked this pull request as draft November 4, 2025 18:36
@AkihiroSuda AkihiroSuda marked this pull request as ready for review November 4, 2025 23:41
@AkihiroSuda AkihiroSuda requested a review from jandubois November 5, 2025 02:42
jandubois
jandubois previously approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@AkihiroSuda AkihiroSuda dismissed jandubois’s stale review November 5, 2025 04:33

The merge-base changed after approval.

jandubois
jandubois previously approved these changes Nov 5, 2025
View reviewed changes
@jandubois
Copy link
Member

jandubois commented Nov 5, 2025

Not sure why GitHub is confused; probably because one of the commits just got merged in a different PR. I'll try closing and re-opening to see if that unbreaks GitHub.

@jandubois jandubois closed this Nov 5, 2025
@jandubois jandubois reopened this Nov 5, 2025
@jandubois jandubois dismissed their stale review November 5, 2025 04:36

The merge-base changed after approval.

@jandubois jandubois merged commit 87e3d91 into lima-vm:master Nov 5, 2025
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandubois jandubois jandubois approved these changes

Assignees

No one assigned

Labels

area/cli limactl CLI user experience area/homebrew Homebrew formula area/vmdrivers VM driver infrastructure

Projects

None yet

Milestone

v2.0.0

2 participants

@AkihiroSuda @jandubois