-
Notifications
You must be signed in to change notification settings - Fork 1
Fix bug for NestedFrame.drop to support 'columns=' #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 19 19
Lines 2089 2093 +4
=======================================
+ Hits 2032 2036 +4
Misses 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
|
Is it ready to review, or still draft? |
dougbrn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you @Graciaaa3 !
gitosaurus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hombit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Fixing the bug of
NestedFrame.drop(columns=...).Previously, when calling
nf.drop(columns=...), the wrapper didn't handle the case where thecolumnsparameter contains nested column. The function directly go tosuper().drop, which resulted in an error.Change Description
closes #367
Solution Description
columnsparameter as a special case that may contain nested column names.columnsinput into(labels, axis)form before callingsuper().drop.Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist