Allow running the CPU pipeline outside of the "recording" abstraction #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
force-pushed
the
full-cpu-pipeline
branch
from
17ffece to
02206ff
Compare
DJMcNab
added a commit
to DJMcNab/vello
that referenced
this pull request
Feb 14, 2025
We already assume these are word-aligned, and so this would catch a failure of that assumption much earller. A future change would be to encode the full scene encoding as u32. That would be useful for linebender#810, as the current code has an alignment hazard
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
We already assume these are word-aligned, and so this would catch a failure of that assumption very early, if it came up. A potential alternative is to store `path_data` as f32 instead, as all values stored are f32. I've not done that for pretty weak reasons, and it should be trivial to change. A future change would be to encode the full scene encoding as `u32`. That would be useful for #810, as the current code has an alignment hazard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step along the path started in #803, of significantly tidying up how our internals work.
The recording API adds a significant amount of extra reasoning work to using Vello's pipeline, whereas as seen in this PR, it isn't actually a huge amount of code to just actually run the pipelines "manually".