-
Notifications
You must be signed in to change notification settings - Fork 49
Add Dockerfile to enable local linux testing on Windows #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 68.74% 68.74%
=======================================
Files 23 23
Lines 4067 4067
Branches 1033 1033
=======================================
Hits 2796 2796
Misses 1127 1127
Partials 144 144 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems legit to me, but if we put it at the root, it is lending some special significance to running .net core 2.1 on ubuntu 18. What might be helpful is to have a build folder with various build assets in it, but it seems strange to pick and choose particular dockerfiles for that purpose. Not sure what to advise here. @asbjornu ?
|
Regarding
Is there a particular benefit to having branches internal to the project? It only seems to make sense to me for long lived branches which will have multiple contributors (and so no natural owner). Is it easier if people create these branches inside the repo for some reason? I must admit I have done it recently without thinking, but perhaps I should be using the forking workflow myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added @sblom to @linked-data-dotnet/contributors, so write access should be available. There is, however, little to gain from having "local" access besides secrets being available in builds (which are unavailable for forked pull requests for security).
Regarding this PR, I would love to see a test doing docker build and docker run of the image so we ensure that it doesn't regress over time.
That's a really good idea. I'll work on this. Will |
ffc3348 to
d2d05b5
Compare
It's a good point. The thing that keeps me fairly calm about having a single somewhat arbitrary standard docker build is that we're really more of a portable nupkg project than a Docker Containers kind of project. :) For what it's worth, that choice of base container image wasn't entirely arbitrary. It's the oldest LTS .NET Core SDK in the Microsoft Container Registry running on the same LTS Ubuntu distro that GitHub Actions runs on. With those parameters, if a developer runs
|
Totally worked. It's container inception, man. |
45e262b to
4d49caa
Compare
I made myself a Dockerfile so that I could test my previous PR against Linux locally, and figure I should share it.
There's definitely zero urgency to this PR. As for the flurry of activity, I ended up taking a some days off to relax at home, and this seemed like a productive use of my energy.
By the way, can I have write (not maintainer or admin) on the
linked-data-dotnet/json-ld.netrepo so that I can do pull requests out of "real" branches instead of my private fork?