cangen: allow to use -m on classical CAN interfaces #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -m option currently only works on CAN FD or CAN XL interfaces. There is a logic to add CAN XL to the mix only if supported but CAN FD is always forced. Modify the -m logic so that only the options supported by the interface are added to the mix. This way: - a Classical CAN interface only mixes -e and -R - a CAN FD interface mixes -e, -R, -f, -b and -E - a CAN XL interface mixes -e, -R, -f, -b, -E and -X This provides a better user experience and also makes -m a good default option for fuzzing any type of CAN interface. Signed-off-by: Vincent Mailhol <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Marc Kleine-Budde <[email protected]>
|
Cc: @vincent-mailhol |
|
This concept mixes the actual frame format (canfd canxl) with the Updated patch: #600 |
|
Please force-push your updated PR over my branch. |
|
To complex. We continue the discussion better in PR 600 |
|
FTR: a git command like this |
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -m option currently only works on CAN FD or CAN XL interfaces. There is a logic to add CAN XL to the mix only if supported but CAN FD is always forced.
Modify the -m logic so that only the options supported by the interface are added to the mix. This way:
This provides a better user experience and also makes -m a good default option for fuzzing any type of CAN interface.