fix(logging): Do not report 'logger.go' as the logging file #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix:
[2023-06-07T15:19:31.783+01:00 I logger.go:53] Registering test step sshcmd
[2023-06-07T15:19:31.783+01:00 I logger.go:53] Registering reporter noop
With this fix:
[2023-06-07T15:12:38.611+01:00 I pluginregistry.go:91] Registering test step sshcmd
[2023-06-07T15:12:38.611+01:00 I pluginregistry.go:115] Registering reporter noop
Signed-off-by: Dmitrii Okunev <[email protected]>
xaionaro
force-pushed
the
bugfix/logging_file
branch
from
62d5b05 to
460569f
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #165 +/- ##
===========================================
+ Coverage 61.65% 61.74% +0.08%
===========================================
Files 130 130
Lines 9199 9209 +10
===========================================
+ Hits 5672 5686 +14
+ Misses 2856 2852 -4
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mimir-d
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix:
With this fix: