feat(conformance): skip test if breaking change is ack #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
|
this PR successfully skips the test since BREAKING CHANGE: is in the commit. |
ashwinb
approved these changes
Sep 30, 2025
.github/workflows/conformance.yml
Outdated
| PR_TITLE="${{ github.event.pull_request.title }}" | ||
| # Skip if title contains "!" indicating breaking change (like "feat!:") | ||
| if [[ "$PR_TITLE" == *"!"* ]]; then |
There was a problem hiding this comment.
how about testing for !: instead (colon after the bang) jsut to be a bit more specific?
if the PR title has `!` or the footer of the commit has `BREAKING CHANGE:`, skip conformance. This is documented in the API leveling proposal Signed-off-by: Charlie Doern <[email protected]>
cdoern
force-pushed
the
conformance-update
branch
from
6760050 to
8a5d360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
if the PR title has
!or the footer of the commit hasBREAKING CHANGE:, skip conformance. This is documented in the API leveling proposal