`#embed` crashes when used in a compound literal

[zygoloid]

This valid C23 source file:

char *p = (char[]){
#embed "/usr/bin/true"
};

crashes clang somewhere in InitListChecker::HandleEmbed.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Richard Smith (zygoloid)

This valid C23 source file:

char *p = (char[]){
#embed "/usr/bin/true"
};

crashes clang somewhere in InitListChecker::HandleEmbed.

[zygoloid]

Presumably the issue is here:

llvm-project/clang/lib/Sema/SemaInit.cpp

Lines 518 to 519 in ce2a3d9

	ValueDecl *ArrDecl = Entity.getParent()->getDecl();
	auto *AType = SemaRef.Context.getAsArrayType(ArrDecl->getType());

An InitializedEntity doesn't necessarily have an associated declaration (but there is a getType() accessor...)

[zygoloid]

@Fznamznon Maybe something like this would work?

- ValueDecl *ArrDecl = Entity.getParent()->getDecl(); 
- auto *AType = SemaRef.Context.getAsArrayType(ArrDecl->getType()); 
+ auto *AType = SemaRef.Context.getAsArrayType(Entity.getParent()->getType()); 

[Fznamznon]

@Fznamznon Maybe something like this would work?

- ValueDecl *ArrDecl = Entity.getParent()->getDecl(); 
- auto *AType = SemaRef.Context.getAsArrayType(ArrDecl->getType()); 
+ auto *AType = SemaRef.Context.getAsArrayType(Entity.getParent()->getType()); 

Yes, it should. I'll create a patch, thank you for reporting this.