[BinaryFormat] Disable MachOTest.UnalignedLC on SPARC #100086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in Issue llvm#86793, the `MachOTest.UnalignedLC` test dies with SIGBUS on SPARC, a strict-alignment target. It simply cannot work there, so this patch disables it. Given that there's doubt about the test's correctnes, one might consider disabling it wholesale. Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`.
|
Given the test has undefined behavior on all big-endian hosts, I'd prefer to do something to fix the issue for all big-endian hosts, not just SPARC. |
|
Disabled now on big-endian in general. |
|
llvm/include/llvm/ADT/bit.h provides define |
|
I'd seen that, but based on I was under the impression that those are implementation details that cannot be relied on. |
You can test this locally with the following command:git-clang-format --diff 430b2545032db9de7898444502915f89e20f7c4c d238831d828149fb396d703f601c9783bcc37ba6 --extensions cpp -- llvm/unittests/BinaryFormat/MachOTest.cppView the diff from clang-format here.diff --git a/llvm/unittests/BinaryFormat/MachOTest.cpp b/llvm/unittests/BinaryFormat/MachOTest.cpp
index 78b20c28a9..46f42f4b7c 100644
--- a/llvm/unittests/BinaryFormat/MachOTest.cpp
+++ b/llvm/unittests/BinaryFormat/MachOTest.cpp
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#include "llvm/ADT/bit.h"
#include "llvm/BinaryFormat/MachO.h"
+#include "llvm/ADT/bit.h"
#include "llvm/TargetParser/Triple.h"
#include "gtest/gtest.h"
|
|
/cherry-pick 3a226db |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 6, 2024
As discussed in Issue llvm#86793, the `MachOTest.UnalignedLC` test dies with `SIGBUS` on SPARC, a strict-alignment target. It simply cannot work there. Besides, the test invokes undefined behaviour on big-endian targets, so this patch disables it on all of those. Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`. (cherry picked from commit 3a226db)
|
/pull-request #102103 |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 10, 2024
As discussed in Issue llvm#86793, the `MachOTest.UnalignedLC` test dies with `SIGBUS` on SPARC, a strict-alignment target. It simply cannot work there. Besides, the test invokes undefined behaviour on big-endian targets, so this patch disables it on all of those. Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`. (cherry picked from commit 3a226db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Issue #86793, the
MachOTest.UnalignedLCtest dies withSIGBUSon SPARC, a strict-alignment target. It simply cannot work there. Besides, the test invokes undefined behaviour on big-endian targets, so this patch disables it on all of those.Tested on
sparcv9-sun-solaris2.11andamd64-pc-solaris2.11.