Skip to content

[PPC][AIX] Save/restore r31 when using base pointer #100182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2024
Merged

[PPC][AIX] Save/restore r31 when using base pointer #100182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5fd2aa
[PPC][AIX] Set needsFP to true when base pointer is used in prologue/…
Jul 23, 2024
069da92
Address review comments
Jul 29, 2024
f379cf4
Address review comments, fix formatting
Jul 29, 2024
d0a2452
Address review comments
Aug 1, 2024
4545ed6
Fix testcase comment
Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@ bool PPCFrameLowering::needsFP(const MachineFunction &MF) const {
if (MF.getFunction().hasFnAttribute(Attribute::Naked))
return false;

if (Subtarget.isAIXABI() && Subtarget.getRegisterInfo()->hasBasePointer(MF))
return true;

return MF.getTarget().Options.DisableFramePointerElim(MF) ||
MFI.hasVarSizedObjects() || MFI.hasStackMap() || MFI.hasPatchPoint() ||
MF.exposesReturnsTwice() ||
Expand Down
13 changes: 10 additions & 3 deletions llvm/test/CodeGen/PowerPC/aix-base-pointer.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@

; Use an overaligned buffer to force base-pointer usage. Test verifies:
; - base pointer register (r30) is saved/defined/restored.
; - frame pointer register (r31) is saved/defined/restored.
; - stack frame is allocated with correct alignment.
; - Address of %AlignedBuffer is calculated based off offset from the stack
; - Address of %AlignedBuffer is calculated based off offset from the frame
; pointer.

define float @caller(float %f) {
Expand All @@ -19,23 +20,29 @@ define float @caller(float %f) {
declare void @callee(ptr)

; 32BIT-LABEL: .caller:
; 32BIT: stw 31, -12(1)
; 32BIT: stw 30, -16(1)
; 32BIT: mr 30, 1
; 32BIT: clrlwi 0, 1, 27
; 32BIT: subfic 0, 0, -224
; 32BIT: stwux 1, 1, 0
; 32BIT: addi 3, 1, 64
; 32BIT: mr 31, 1
; 32BIT: addi 3, 31, 64
; 32BIT: bl .callee
; 32BIT: mr 1, 30
; 32BIT: lwz 31, -12(1)
; 32BIT: lwz 30, -16(1)

; 64BIT-LABEL: .caller:
; 64BIT: std 31, -16(1)
; 64BIT: std 30, -24(1)
; 64BIT: mr 30, 1
; 64BIT: clrldi 0, 1, 59
; 64BIT: subfic 0, 0, -288
; 64BIT: stdux 1, 1, 0
; 64BIT: addi 3, 1, 128
; 64BIT: mr 31, 1
; 64BIT: addi 3, 31, 128
; 64BIT: bl .callee
; 64BIT: mr 1, 30
; 64BIT: ld 31, -16(1)
; 64BIT: ld 30, -24(1)
Loading