Skip to content

Conversation

@vporpo
Copy link

@vporpo vporpo commented Jul 26, 2024

This patch implements sandboxir::CallBrInst which mirrors llvm::CallBrInst.

LLVM IR does not expose the Uses to DefaultDest and IndirectDest so we need special Tracker objects for both of setters.

This patch implements sandboxir::CallBrInst which mirrors llvm::CallBrInst.

LLVM IR does not expose the Uses to DefaultDest and IndirectDest so we need
special Tracker objects for both of setters.
Copy link
Member

@tmsri tmsri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is inline with how other instructions were added.

@vporpo vporpo merged commit cfb92be into llvm:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants