Skip to content

Conversation

@tstellar
Copy link
Collaborator

@tstellar tstellar commented Aug 5, 2024

Now that the release binaries create artifact attestations, we need to ensure that we call the workflow with the correct permissions.

Now that the release binaries create artifact attestations, we need
to ensure that that workflow has the correct permissions.
@tstellar tstellar requested a review from tru August 5, 2024 17:28
@tstellar
Copy link
Collaborator Author

tstellar commented Aug 5, 2024

@llvmbot
Copy link
Member

llvmbot commented Aug 5, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

Now that the release binaries create artifact attestations, we need to ensure that we call the workflow with the correct permissions.


Full diff: https://github.com/llvm/llvm-project/pull/102023.diff

1 Files Affected:

  • (modified) .github/workflows/release-tasks.yml (+2)
diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml
index 7dd4c306671b7..b7fea0785fed2 100644
--- a/.github/workflows/release-tasks.yml
+++ b/.github/workflows/release-tasks.yml
@@ -78,6 +78,8 @@ jobs:
     name: Build Release Binaries
     permissions:
       contents: write
+      id-token: write
+      attestations: write
     needs:
       - validate-tag
       - release-create

@tstellar tstellar changed the title workflows/release-tasks: Add missing permissions for release binaires workflows/release-tasks: Add missing permissions for release binaries Aug 5, 2024
@tstellar tstellar merged commit dc349a3 into llvm:main Aug 5, 2024
@tstellar tstellar added this to the LLVM 19.X Release milestone Aug 5, 2024
@tstellar
Copy link
Collaborator Author

tstellar commented Aug 5, 2024

/cherry-pick dc349a3

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Aug 5, 2024
…llvm#102023)

Now that the release binaries create artifact attestations, we need to
ensure that we call the workflow with the correct permissions.

(cherry picked from commit dc349a3)
@llvmbot
Copy link
Member

llvmbot commented Aug 5, 2024

/pull-request #102057

tru pushed a commit to llvmbot/llvm-project that referenced this pull request Aug 10, 2024
…llvm#102023)

Now that the release binaries create artifact attestations, we need to
ensure that we call the workflow with the correct permissions.

(cherry picked from commit dc349a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants