Skip to content

[llvm] Remove redundant calls to std::unique_ptr<T>::get (NFC) #113415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[llvm] Remove redundant calls to std::unique_ptr<T>::get (NFC) #113415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/CGData/CodeGenData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ CodeGenData &CodeGenData::getInstance() {
Instance->publishOutlinedHashTree(Reader->releaseOutlinedHashTree());
}
});
return *(Instance.get());
return *Instance;
}

namespace IndexedCGData {
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/CodeGen/MachineOutliner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,7 @@ void MachineOutliner::emitOutlinedHashTree(Module &M) {

Triple TT(M.getTargetTriple());
embedBufferInModule(
M, *Buffer.get(),
M, *Buffer,
getCodeGenDataSectionName(CG_outline, TT.getObjectFormat()));
}
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Support/TimeProfiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ struct llvm::TimeTraceProfiler {
if (Stack.empty())
return;

Stack.back().get()->InstantEvents.emplace_back(TimeTraceProfilerEntry(
Stack.back()->InstantEvents.emplace_back(TimeTraceProfilerEntry(
ClockType::now(), TimePointType(), std::move(Name), Detail(),
TimeTraceEventType::InstantEvent));
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ class SchedGroup {
bool allowedByRules(const SUnit *SU,
SmallVectorImpl<SchedGroup> &SyncPipe) const {
for (auto &Rule : Rules) {
if (!Rule.get()->apply(SU, Collection, SyncPipe))
if (!Rule->apply(SU, Collection, SyncPipe))
return false;
}
return true;
Expand Down
14 changes: 7 additions & 7 deletions llvm/unittests/IR/DroppedVariableStatsTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ TEST(DroppedVariableStats, BothDeleted) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
I.eraseFromParent();
Expand Down Expand Up @@ -141,7 +141,7 @@ TEST(DroppedVariableStats, DbgValLost) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down Expand Up @@ -198,7 +198,7 @@ TEST(DroppedVariableStats, UnrelatedScopes) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down Expand Up @@ -255,7 +255,7 @@ TEST(DroppedVariableStats, ChildScopes) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down Expand Up @@ -313,7 +313,7 @@ TEST(DroppedVariableStats, InlinedAt) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down Expand Up @@ -371,7 +371,7 @@ TEST(DroppedVariableStats, InlinedAtShared) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down Expand Up @@ -430,7 +430,7 @@ TEST(DroppedVariableStats, InlinedAtChild) {
llvm::Any(const_cast<const llvm::Module *>(M.get())));

// This loop simulates an IR pass that drops debug information.
for (auto &F : *M.get()) {
for (auto &F : *M) {
for (auto &I : instructions(&F)) {
I.dropDbgRecords();
break;
Expand Down
Loading