Skip to content

Conversation

@JDevlieghere
Copy link
Member

@JDevlieghere JDevlieghere commented Aug 1, 2025

PythonObject::Dump isn't called and uses _PyObject_Dump, which isn't part of the stable API.

Part of #151617.

PythonObject::Dump isn't called and uses `_PyObject_Dump`, which isn't
part of the stable API.
@llvmbot
Copy link
Member

llvmbot commented Aug 1, 2025

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

Changes

PythonObject::Dump isn't called and uses _PyObject_Dump, which isn't part of the stable API.

Part of #151617.


Full diff: https://github.com/llvm/llvm-project/pull/151783.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h (-7)
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
index 6a5dd43096363..b73e2a97da3c3 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
@@ -250,13 +250,6 @@ class PythonObject {
 
   void Reset();
 
-  void Dump() const {
-    if (m_py_obj)
-      _PyObject_Dump(m_py_obj);
-    else
-      puts("NULL");
-  }
-
   void Dump(Stream &strm) const;
 
   PyObject *get() const { return m_py_obj; }

@JDevlieghere JDevlieghere merged commit 154354e into llvm:main Aug 1, 2025
11 checks passed
@JDevlieghere JDevlieghere deleted the python-object-dump branch August 1, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants