[NFC][run-clang-tidy] Add minor type hints #151873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script passes ``` python3 -m mypy --strict clang-tools-extra/clang-tidy/tool/run-clang-tidy.py ``` `args` and `kwargs` can be typed with what we expect for a single argument. In this case, since we forward to `print`, `Any` seems best.
|
@llvm/pr-subscribers-clang-tidy Author: Nicolas van Kempen (nicovank) ChangesThis script passes
Full diff: https://github.com/llvm/llvm-project/pull/151873.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index d307b26ea0d34..80f1766b0bf10 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -236,7 +236,7 @@ def print_profile_data(aggregated_data: Dict[str, float]) -> None:
checkers.items(), key=lambda x: x[1]["user"] + x[1]["sys"], reverse=True
)
- def print_stderr(*args, **kwargs) -> None:
+ def print_stderr(*args: Any, **kwargs: Any) -> None:
print(*args, file=sys.stderr, **kwargs)
print_stderr(
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Nicolas van Kempen (nicovank) ChangesThis script passes
Full diff: https://github.com/llvm/llvm-project/pull/151873.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index d307b26ea0d34..80f1766b0bf10 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -236,7 +236,7 @@ def print_profile_data(aggregated_data: Dict[str, float]) -> None:
checkers.items(), key=lambda x: x[1]["user"] + x[1]["sys"], reverse=True
)
- def print_stderr(*args, **kwargs) -> None:
+ def print_stderr(*args: Any, **kwargs: Any) -> None:
print(*args, file=sys.stderr, **kwargs)
print_stderr(
|
|
Unfortunately there is no CI setup for this. |
vbvictor
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script passes
argsandkwargscan be typed with what we expect for a single argument. In this case, since we forward toprint,Anyseems best.