Skip to content

[clang][Interp] Implement compound assign operators on bitfields #67306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2023
Merged

[clang][Interp] Implement compound assign operators on bitfields #67306

merged 1 commit into from
Oct 14, 2023

Conversation

@tbaederr
Copy link
Contributor

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 25, 2023
@tbaederr
Copy link
Contributor Author

tbaederr commented Oct 2, 2023

Ping

cor3ntin
cor3ntin approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i tried to think of a nicer way to avoid the duplication for discarded statements but..i don't have anything

@tbaederr tbaederr merged commit a653749 into llvm:main Oct 14, 2023
@madhur13490 madhur13490 mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cor3ntin cor3ntin cor3ntin approved these changes

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

@shafik shafik Awaiting requested review from shafik

@erichkeane erichkeane Awaiting requested review from erichkeane

Assignees

No one assigned

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbaederr @cor3ntin @llvmbot