[lldb][test] Remove expected failure marker for TestPlatformAttach on windows #68193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… windows Looks like this test pass since llvm#68050.
Member
|
@llvm/pr-subscribers-lldb ChangesLooks like this test pass since #68050. Full diff: https://github.com/llvm/llvm-project/pull/68193.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
index d62e86b2a3c1d20..2aaf962b9e4f9a5 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
@@ -7,7 +7,6 @@
class TestPlatformAttach(GDBRemoteTestBase):
@skipIfRemote
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr52451")
def test_attach(self):
"""Test attaching by name"""
|
DavidSpickett
approved these changes
Oct 4, 2023
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
Might as well go ahead and try this. If it's still unstable by end of your work day, add a skipifwindows and let Jonas look into it.
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 4, 2023
… windows (llvm#68193) Looks like this test passes since llvm#68050. (cherry picked from commit 75f295c)
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 9, 2023
… windows (llvm#68193) Looks like this test passes since llvm#68050. (cherry picked from commit 75f295c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this test passes since #68050.