Skip to content

Conversation

@PeimingLiu
Copy link
Member

No description provided.

@llvmbot llvmbot added mlir:sparse Sparse compiler in MLIR mlir labels Oct 13, 2023
@PeimingLiu PeimingLiu changed the title [mlir][sparse] implementating stage convertOp as an interface [mlir][sparse] implementating stageSparseOpPass as an interface Oct 13, 2023
Copy link
Contributor

@aartbik aartbik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once addressed

@PeimingLiu PeimingLiu merged commit 761c9dd into llvm:main Oct 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 1ebe73821f4cefa48d7e3d24e62303412ab9ad25 115dc30d51c166545846486f70b0ec97b7fa50da -- mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h mlir/lib/Dialect/SparseTensor/IR/SparseTensorInterfaces.cpp mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp mlir/lib/Dialect/SparseTensor/Transforms/StageSparseOperations.cpp
View the diff from clang-format here.
diff --git a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
index ebbc522123a5..15f1fa0e5da9 100644
--- a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
+++ b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
@@ -1,5 +1,5 @@
 //===- SparseTensorInterfaces.h - sparse tensor operations
-//interfaces-------===//
+// interfaces-------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.

Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 20, 2023
Local branch amd-gfx 5dff4b9 Merged main:20af0e5e8d56 into amd-gfx:ca63cea7fda3
Remote branch main 761c9dd [mlir][sparse] implementating stageSparseOpPass as an interface (llvm#69022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir:sparse Sparse compiler in MLIR mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants