Skip to content

[lld][NFC] Factor out isCodeSection helper. #69193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[lld][NFC] Factor out isCodeSection helper. #69193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lld/COFF/Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,11 +1403,7 @@ void Writer::assignAddresses() {

// If /FUNCTIONPADMIN is used, functions are padded in order to create a
// hotpatchable image.
const bool isCodeSection =
(sec->header.Characteristics & IMAGE_SCN_CNT_CODE) &&
(sec->header.Characteristics & IMAGE_SCN_MEM_READ) &&
(sec->header.Characteristics & IMAGE_SCN_MEM_EXECUTE);
uint32_t padding = isCodeSection ? config->functionPadMin : 0;
uint32_t padding = sec->isCodeSection() ? config->functionPadMin : 0;

for (Chunk *c : sec->chunks) {
if (padding && c->isHotPatchable())
Expand Down
6 changes: 6 additions & 0 deletions lld/COFF/Writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ class OutputSection {
// Used only when the name is longer than 8 bytes.
void setStringTableOff(uint32_t v) { stringTableOff = v; }

bool isCodeSection() const {
return (header.Characteristics & llvm::COFF::IMAGE_SCN_CNT_CODE) &&
(header.Characteristics & llvm::COFF::IMAGE_SCN_MEM_READ) &&
(header.Characteristics & llvm::COFF::IMAGE_SCN_MEM_EXECUTE);
}

// N.B. The section index is one based.
uint32_t sectionIndex = 0;

Expand Down