Skip to content

[SLP] Improve gather tree nodes matching when users are PHIs. #69392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

[SLP] Improve gather tree nodes matching when users are PHIs. #69392

merged 1 commit into from
Oct 18, 2023

Conversation

@valerydmit
Copy link
Contributor

@valerydmit valerydmit commented Oct 17, 2023

No description provided.

alexey-bataev
alexey-bataev approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@alexey-bataev alexey-bataev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@valerydmit valerydmit merged commit c80b503 into llvm:main Oct 18, 2023
@valerydmit valerydmit deleted the improve_is_gather_shuffled_entry branch October 18, 2023 16:10
@madhur13490 madhur13490 mentioned this pull request Oct 20, 2023
Closed
dyung added a commit that referenced this pull request Oct 20, 2023
@dyung
Revert "[SLP] Improve gather tree nodes matching when users are PHIs. (…
734b016 
…#69392)"

This reverts commit c80b503.

This change causes a fatal error in the backend and is filed as issue #69670.
@spupyrev spupyrev mentioned this pull request Oct 23, 2023
Merged
@banach-space banach-space mentioned this pull request Oct 24, 2023
Merged
@valerydmit valerydmit mentioned this pull request Oct 24, 2023
Merged
valerydmit pushed a commit to valerydmit/llvm-project that referenced this pull request Oct 24, 2023
[SLP] Improve gather tree nodes matching when users are PHIs.
f324d4e 
This is re-commit of llvm#69392 and also fixes issue llvm#69670
which was uncovered with the prior commit.
For delayed gather emission it may be incorrect to use stab
instruction as insertion point if it is a PHI operand.
For that case insertion point is adjusted to be at the end of block,
ensuring that prior dependecy vector code is emitted earlier.
@valerydmit valerydmit mentioned this pull request Oct 24, 2023
Merged
valerydmit pushed a commit that referenced this pull request Oct 24, 2023
[SLP] Improve gather tree nodes matching when users are PHIs. (#70111)
3324776 
This is re-commit of #69392 and also fixes issue #69670 which was
uncovered with the prior commit.
For delayed gather emission it may be incorrect to use stab instruction
as insertion point if it is a PHI operand. For that case insertion point
is adjusted to be at the end of block, ensuring that prior dependecy
vector code is emitted earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-bataev alexey-bataev alexey-bataev approved these changes

@RKSimon RKSimon Awaiting requested review from RKSimon

Assignees

No one assigned

Labels

llvm:transforms vectorizers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valerydmit @alexey-bataev @llvmbot