[MC] Teach checkAsmTiedOperandConstraints about optional operands #81381
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Attached is a readable diff (updated). |
|
I'll try to pull the duplicate logic to some common place. (I'll need to modify it in the next PR.) |
At some point in the past, optional operands have become allowed in the middle of an instruction. However, `checkAsmTiedOperandConstrains` hasn't been modified to support this. This patch adds the support by copying the necessary logic from `convertToMCInst`.
s-barannikov
force-pushed
the
asm-matcher-emitter/optional-operand-between-constrained
branch
from
0bd96c2 to
a38f0a0
Compare
|
ping |
1 similar comment
|
ping |
|
Ah very nice, presumably this fixes some of the issues I ran into, but looks like better solution than my hack. |
|
If possible some extra comments about the logic behind the operand indices would be appreciated as the logic in this file is already pretty inexplicable. Other than that LGTM |
Sure, I'll see what I can come up with. |
|
@AlfieRichardsArm |
|
Looks great thank you |
s-barannikov
deleted the
asm-matcher-emitter/optional-operand-between-constrained
branch
2 participants
At some point in the past, optional operands have become allowed in the middle of an instruction. However,
checkAsmTiedOperandConstrainshasn't been modified to support this. This patch adds the support by pulling operand offsets counting out ofconvertToMCInstand reusing it incheckAsmTiedOperandConstrains.