[NFC][OpenMP] Add test checking clang offload chunking policy #83261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify how clang handles `dist_schedule(static, block_chunk)` and `schedule(static, thread_chunk)` clauses for OpenMP offload loop workshare pragmas.
uweigand
added a commit
that referenced
this pull request
Mar 20, 2024
The test added by #83261 has been consistently failing. Mark as UNSUPPORTED just like on x86_64 and aarch64.
|
This test has been consistently failing on s390x-ibm-linux-gnu and s390x-ibm-linux-gnu-LTO. I've now marked those two targets as unsupported, just like x86_64 and aarch64 already were. I notice that a significant number of the offloading tests are all marked as UNSUPPORTED on the "server" CPU targets (x86_64, aarch64 and s390x) - maybe this could be abstracted in some better way? |
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
…3261) Verify how clang handles `dist_schedule(static, block_chunk)` and `schedule(static, thread_chunk)` clauses for OpenMP offload loop workshare pragmas.
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
The test added by llvm#83261 has been consistently failing. Mark as UNSUPPORTED just like on x86_64 and aarch64.
Yes, we should have "feature flags" rather than listing targets. Here it would be "required teams". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify how clang handles
dist_schedule(static, block_chunk)andschedule(static, thread_chunk)clauses for OpenMP offload loop workshare pragmas.