[SPARC][IAS] Add support for prefetcha instruction
#94250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Member
|
@llvm/pr-subscribers-mc Author: Koakuma (koachan) ChangesThis adds support for Full diff: https://github.com/llvm/llvm-project/pull/94250.diff 3 Files Affected:
diff --git a/llvm/lib/Target/Sparc/SparcInstrInfo.td b/llvm/lib/Target/Sparc/SparcInstrInfo.td
index f1778f2162f8c..cac96a1398721 100644
--- a/llvm/lib/Target/Sparc/SparcInstrInfo.td
+++ b/llvm/lib/Target/Sparc/SparcInstrInfo.td
@@ -1782,6 +1782,13 @@ let Predicates = [HasV9] in {
def PREFETCHi : F3_2<3, 0b101101,
(outs), (ins (MEMri $rs1, $simm13):$addr, PrefetchTag:$rd),
"prefetch [$addr], $rd", []>;
+ def PREFETCHAr : F3_1_asi<3, 0b111101, (outs),
+ (ins (MEMrr $rs1, $rs2):$addr, ASITag:$asi, PrefetchTag:$rd),
+ "prefetcha [$addr] $asi, $rd", []>;
+ let Uses = [ASR3] in
+ def PREFETCHAi : F3_2<3, 0b111101, (outs),
+ (ins (MEMri $rs1, $simm13):$addr, PrefetchTag:$rd),
+ "prefetcha [$addr] %asi, $rd", []>;
}
diff --git a/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt b/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
index 9286814552cf5..1d1fdb667fafa 100644
--- a/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
+++ b/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
@@ -32,3 +32,8 @@
0xd5 0xf6 0x11 0x56
# V9: casxa [%i0] #ASI_SNF_L, %l6, %o2
0xd5 0xf6 0x11 0x76
+
+# V9: prefetcha [%i1+3968] %asi, #one_read
+0xc3 0xee 0x6f 0x80
+# V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read
+0xc3 0xee 0x50 0x7a
diff --git a/llvm/test/MC/Sparc/sparcv9-instructions.s b/llvm/test/MC/Sparc/sparcv9-instructions.s
index f0348eb70f1c5..ae8646f8bc560 100644
--- a/llvm/test/MC/Sparc/sparcv9-instructions.s
+++ b/llvm/test/MC/Sparc/sparcv9-instructions.s
@@ -557,6 +557,36 @@
! V9: prefetch [%i1+%i2], #one_read ! encoding: [0xc3,0x6e,0x40,0x1a]
prefetch [ %i1 + %i2 ], #one_read
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + 0xf80 ] %asi, 1
+ ! V9: prefetcha [%i1+3968] %asi, #one_read ! encoding: [0xc3,0xee,0x6f,0x80]
+ prefetcha [ %i1 + 0xf80 ] %asi, 1
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + 0xf80 ] %asi, #one_read
+ ! V9: prefetcha [%i1+3968] %asi, #one_read ! encoding: [0xc3,0xee,0x6f,0x80]
+ prefetcha [ %i1 + 0xf80 ] %asi, #one_read
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] #ASI_SNF, 1
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] #ASI_SNF, 1
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] #ASI_SNF, #one_read
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] #ASI_SNF, #one_read
+
+ ! V8: error: invalid operand for instruction
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] 131, 1
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] 131, 1
+
+ ! V8: error: unexpected token
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] 131, #one_read
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] 131, #one_read
+
! V8: error: instruction requires a CPU feature not currently enabled
! V8-NEXT: done
! V9: done ! encoding: [0x81,0xf0,0x00,0x00]
|
Member
|
@llvm/pr-subscribers-backend-sparc Author: Koakuma (koachan) ChangesThis adds support for Full diff: https://github.com/llvm/llvm-project/pull/94250.diff 3 Files Affected:
diff --git a/llvm/lib/Target/Sparc/SparcInstrInfo.td b/llvm/lib/Target/Sparc/SparcInstrInfo.td
index f1778f2162f8c..cac96a1398721 100644
--- a/llvm/lib/Target/Sparc/SparcInstrInfo.td
+++ b/llvm/lib/Target/Sparc/SparcInstrInfo.td
@@ -1782,6 +1782,13 @@ let Predicates = [HasV9] in {
def PREFETCHi : F3_2<3, 0b101101,
(outs), (ins (MEMri $rs1, $simm13):$addr, PrefetchTag:$rd),
"prefetch [$addr], $rd", []>;
+ def PREFETCHAr : F3_1_asi<3, 0b111101, (outs),
+ (ins (MEMrr $rs1, $rs2):$addr, ASITag:$asi, PrefetchTag:$rd),
+ "prefetcha [$addr] $asi, $rd", []>;
+ let Uses = [ASR3] in
+ def PREFETCHAi : F3_2<3, 0b111101, (outs),
+ (ins (MEMri $rs1, $simm13):$addr, PrefetchTag:$rd),
+ "prefetcha [$addr] %asi, $rd", []>;
}
diff --git a/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt b/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
index 9286814552cf5..1d1fdb667fafa 100644
--- a/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
+++ b/llvm/test/MC/Disassembler/Sparc/sparc-v9-asi.txt
@@ -32,3 +32,8 @@
0xd5 0xf6 0x11 0x56
# V9: casxa [%i0] #ASI_SNF_L, %l6, %o2
0xd5 0xf6 0x11 0x76
+
+# V9: prefetcha [%i1+3968] %asi, #one_read
+0xc3 0xee 0x6f 0x80
+# V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read
+0xc3 0xee 0x50 0x7a
diff --git a/llvm/test/MC/Sparc/sparcv9-instructions.s b/llvm/test/MC/Sparc/sparcv9-instructions.s
index f0348eb70f1c5..ae8646f8bc560 100644
--- a/llvm/test/MC/Sparc/sparcv9-instructions.s
+++ b/llvm/test/MC/Sparc/sparcv9-instructions.s
@@ -557,6 +557,36 @@
! V9: prefetch [%i1+%i2], #one_read ! encoding: [0xc3,0x6e,0x40,0x1a]
prefetch [ %i1 + %i2 ], #one_read
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + 0xf80 ] %asi, 1
+ ! V9: prefetcha [%i1+3968] %asi, #one_read ! encoding: [0xc3,0xee,0x6f,0x80]
+ prefetcha [ %i1 + 0xf80 ] %asi, 1
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + 0xf80 ] %asi, #one_read
+ ! V9: prefetcha [%i1+3968] %asi, #one_read ! encoding: [0xc3,0xee,0x6f,0x80]
+ prefetcha [ %i1 + 0xf80 ] %asi, #one_read
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] #ASI_SNF, 1
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] #ASI_SNF, 1
+
+ ! V8: error: malformed ASI tag, must be a constant integer expression
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] #ASI_SNF, #one_read
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] #ASI_SNF, #one_read
+
+ ! V8: error: invalid operand for instruction
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] 131, 1
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] 131, 1
+
+ ! V8: error: unexpected token
+ ! V8-NEXT: prefetcha [ %i1 + %i2 ] 131, #one_read
+ ! V9: prefetcha [%i1+%i2] #ASI_SNF, #one_read ! encoding: [0xc3,0xee,0x50,0x7a]
+ prefetcha [ %i1 + %i2 ] 131, #one_read
+
! V8: error: instruction requires a CPU feature not currently enabled
! V8-NEXT: done
! V9: done ! encoding: [0x81,0xf0,0x00,0x00]
|
Contributor
Author
|
Note: this PR was created by |
s-barannikov
reviewed
Jun 3, 2024
s-barannikov
approved these changes
Jun 4, 2024
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
koachan
changed the base branch from
users/koachan/spr/main.sparcias-add-support-for-prefetcha-instruction
to
main
koachan
deleted the
users/koachan/spr/sparcias-add-support-for-prefetcha-instruction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
prefetchainstruction for prefetching fromalternate address spaces.