[test] Skip some tests on Windows only #95205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests do not require bash. Skip them because they use features not available on Windows. This is a follow up to llvm#94595.
Member
|
@llvm/pr-subscribers-debuginfo Author: Jay Foad (jayfoad) ChangesThese tests do not require bash. Skip them because they use features not Full diff: https://github.com/llvm/llvm-project/pull/95205.diff 3 Files Affected:
diff --git a/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test b/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
index 5141ff6ce322c..63c9f82bb0a63 100644
--- a/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
+++ b/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
@@ -1,4 +1,6 @@
-# REQUIRES: shell
+# This test uses symlinks.
+UNSUPPORTED: system-windows
+
# Ensure that no realpath assumptions are made about .gnu_debuglink paths.
# Copy inputs to some other location with arbitrary names, with the original
diff --git a/llvm/test/Other/lit-unicode.txt b/llvm/test/Other/lit-unicode.txt
index 2f40001451688..d884337d7cb2e 100644
--- a/llvm/test/Other/lit-unicode.txt
+++ b/llvm/test/Other/lit-unicode.txt
@@ -1,5 +1,5 @@
-FIXME: See if we can fix this in lit by using Unicode strings.
-REQUIRES: shell
+Windows echo does not have good Unicode support.
+UNSUPPORTED: system-windows
RUN: echo "ようこそ" | FileCheck %s
CHECK: {{^}}ようこそ{{$}}
diff --git a/llvm/test/tools/llvm-rc/windres-prefix.test b/llvm/test/tools/llvm-rc/windres-prefix.test
index 4c53fdfc3db65..a907666284704 100644
--- a/llvm/test/tools/llvm-rc/windres-prefix.test
+++ b/llvm/test/tools/llvm-rc/windres-prefix.test
@@ -1,4 +1,5 @@
-; REQUIRES: shell
+; This test uses symlinks.
+; UNSUPPORTED: system-windows
; RUN: rm -rf %t && mkdir %t
|
zmodem
reviewed
Jun 12, 2024
| FIXME: See if we can fix this in lit by using Unicode strings. | ||
| REQUIRES: shell | ||
| Windows echo does not have good Unicode support. | ||
| UNSUPPORTED: system-windows |
Collaborator
There was a problem hiding this comment.
Does something like RUN: python3 -c 'print("ようこそ")' | FileCheck %s work?
Collaborator
There was a problem hiding this comment.
FTR, the test works fine for me on Windows, unless I force it to use the gnuwin32 echo instead of cmd's echo.
Maybe use printf instead of echo? That worked in my environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests do not require bash. Skip them because they use features not
available on Windows. This is a follow up to #94595.