[Clang] Simplify release notes and remove irrelevant comment #96407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Gábor Spaits (spaits) ChangesAs discussed before with @cor3ntin before (#94752) here is the simplification of the release note written for the previously mentioned PR and the removal of a comment that is no longer useful. (Sorry for creating this PR this late.) Full diff: https://github.com/llvm/llvm-project/pull/96407.diff 2 Files Affected:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 9c8f8c4a4fbaf..d32a85f2fb698 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -224,9 +224,6 @@ C++20 Feature Support
``<expected>`` from libstdc++ to work correctly with Clang.
- User defined constructors are allowed for copy-list-initialization with CTAD.
- The example code for deduction guides for std::map in
- (`cppreference <https://en.cppreference.com/w/cpp/container/map/deduction_guides>`_)
- will now work.
(#GH62925).
C++23 Feature Support
diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp
index f820db5233f53..a27f97ae739f5 100644
--- a/clang/lib/Sema/SemaInit.cpp
+++ b/clang/lib/Sema/SemaInit.cpp
@@ -11041,9 +11041,6 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer(
// C++ [over.best.ics]p4:
// When [...] the constructor [...] is a candidate by
// - [over.match.copy] (in all cases)
- // FIXME: The "second phase of [over.match.list] case can also
- // theoretically happen here, but it's not clear whether we can
- // ever have a parameter of the right type.
if (TD) {
SmallVector<Expr *, 8> TmpInits;
for (Expr *E : Inits)
|
cor3ntin
approved these changes
Jul 6, 2024
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/873 Here is the relevant piece of the build log for the reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before with @cor3ntin before (#94752) here is the simplification of the release note written for the previously mentioned PR and the removal of a comment that is no longer useful.
(Sorry for creating this PR this late.)