[SandboxIR] Implement SelectInst #99996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I just realized I need to add some tests to exercise the |
tmsri
reviewed
Jul 23, 2024
llvm/lib/SandboxIR/SandboxIR.cpp
Outdated
Member
There was a problem hiding this comment.
Maybe a createCommon here too like ReturnInst to capture the duplication?
tmsri
reviewed
Jul 23, 2024
Member
There was a problem hiding this comment.
Would it be worth checking *(BB->end())->getOpcodeName() == Select here?
Author
There was a problem hiding this comment.
Well, this is automatically handled by the .def files, so it shouldn't normally be wrong. But yeah, at some point we should check this too.
It will be checked once we add tests for the dump() functions for the whole class hierarchy in a future patch.
tmsri
approved these changes
Jul 23, 2024
Member
tmsri
left a comment
tmsri
left a comment
There was a problem hiding this comment.
Fine after addressing some minor comments. Very similar to other instruction classes.
This patch implements sandboxir::SelectInst which mirrors llvm::SelectInst.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This patch implements sandboxir::SelectInst which mirrors llvm::SelectInst. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements sandboxir::SelectInst which mirrors llvm::SelectInst.