[TorchToLinalg] Use linalg.transpose instead of generic in permuteTensor
#3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teTensor`` This PR changes the lowering to use `linalg.transpose` instead of `linalg.generic` in `torch_to_linalg::permuteTensor`.
CoTinker
changed the title
linalg.transpose instead of generic in permuteTensor`linalg.transpose instead of generic in permuteTensor
ubfx
reviewed
Nov 14, 2024
Member
ubfx
left a comment
ubfx
left a comment
There was a problem hiding this comment.
I think this makes sense, but there seems to be a problem with 0D-tensors in the e2e tests?
Contributor
Author
|
I'll take a look at it. |
vivekkhandelwal1
requested changes
Nov 14, 2024
Collaborator
vivekkhandelwal1
left a comment
vivekkhandelwal1
left a comment
There was a problem hiding this comment.
You need to add a check for the zero-ranked input. Rest all looks fine.
Contributor
Author
|
I wonder if we should add a folder for |
Collaborator
Yeah, that's a nice thing to do. You may do it in the same PR or in another one as you wish. |
Contributor
Author
|
Thanks, I think it's better to open another PR for the folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the lowering to use
linalg.transposeinstead oflinalg.genericintorch_to_linalg::permuteTensor.