docker: Use openSUSE Leap as a base image for all stages #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
fix-builder-image
branch
3 times, most recently
from
447c47e to
a22d733
Compare
vadorovsky
force-pushed
the
fix-builder-image
branch
2 times, most recently
from
30897db to
0cc5e4b
Compare
vadorovsky
commented
Nov 22, 2021
| ghcr.io/rancher-sandbox/lockc:latest | ||
| - | ||
| name: Retrieve pull request number | ||
| if: ${{ startsWith(github.ref, 'refs/pull/') }} |
Member
Author
There was a problem hiding this comment.
@nickgerace I have an explanation for those if statements now.
So, this whole file is triggered by many events which are mutual exclusive when it comes to pushing images. We trigger this workflow on:
- push to
mainbranch (merging a PR) (github.refisrefs/heads/*) - creating a tag (
github.refisrefs/tags/*) - submitting a pull request (
github.refisrefs/pull/*)
For all of those actions we want to build an image, but we want to push it differently. To handle then differently, we need to catch them with if statements.
That's why we do:
if: ${{ startsWith(github.ref, 'refs/pull/') }}if: ${{ startsWith(github.ref, 'refs/heads/') }}if: ${{ startsWith(github.ref, 'refs/tags/') }}
Collaborator
There was a problem hiding this comment.
thanks for the explanation!
We had problems with building based on the official Rust image, based on Debian. It's more convenient if we just stick to openSUSE and manage all dependencies ourselves. Signed-off-by: Michal Rostecki <[email protected]>
vadorovsky
force-pushed
the
fix-builder-image
branch
2 times, most recently
from
29fcfa6 to
21593a1
Compare
This change adds container builds for pull requests. For two reasons: 1) In case of failures on the main branch, to check whether a pull request aiming to fix them really fixes them. 2) Might be nice for testing someones' changes before merging, without necessity to check out and build their code. Signed-off-by: Michal Rostecki <[email protected]>
vadorovsky
force-pushed
the
fix-builder-image
branch
from
21593a1 to
1399d36
Compare
nickgerace
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had problems with building based on the official Rust image, based on
Debian. It's more convenient if we just stick to openSUSE and manage all
dependencies ourselves.
This PR also adds container builds for pull requests. For two reasons: