Build container images on push #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to build container images only on push to main branch. We shouldn't care about building images from PR. Signed-off-by: Michal Jura <[email protected]>
vadorovsky
requested changes
Nov 30, 2021
There was a problem hiding this comment.
We shouldn't care about building images from PR.
I strongly disagree. I think that building images from PRs is really convenient for two reasons:
- you can easily test someone's changes without checking out to their branch, compiling and building an image yourself
- we can introduce some integration tests on top of those images in future
So I would rather try to fix PR image builds.
vadorovsky
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to build container images only on push to main branch.
We shouldn't care about building images from PR.