Add support for Docker #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
requested changes
Oct 11, 2021
Member
vadorovsky
left a comment
vadorovsky
left a comment
There was a problem hiding this comment.
The code looks good. Good job! 💯
I would edit the commit message a bit. I don't think that the following info is useful:
(cherry picked from commit 2dcad30)
it's some commit from a closed PR. I would remove that line and add Fixes: #57 somewhere to automatically close the issue once the PR is merged.
mjura
force-pushed
the
docker-support
branch
2 times, most recently
from
bb30f54 to
40e60a7
Compare
Adding support for Docker containers and enforce lockc profiles. Example usage can be: docker run --label org.lockc.policy=privileged [image] Fixes: lockc-project#57 Signed-off-by: Michal Jura <[email protected]>
vadorovsky
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Docker containers and enforce lockc profiles.
Example usage can be:
docker run --label org.lockc.policy=privileged [image]
Fixes: #57