Skip to content

Conversation

@yaauie
Copy link
Contributor

@yaauie yaauie commented Mar 17, 2021

The "HTTP Compression" section of the docs leaks a lot of obsolete details about how Elasticsearch needs to be configured, which obscures how this plugin is used.

@yaauie yaauie requested a review from karenzone March 17, 2021 19:43
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting and simplifying! LGTM

@karenzone
Copy link
Contributor

Screen Shot 2021-03-17 at 6 25 26 PM

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions inline wrt capitalization and tense. Otherwise, LGTM 🚀
Nice improvements. Thank you!

@yaauie yaauie merged commit 0862069 into master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants