ES 1.x gets the ES 2.x template #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the current behavior anyway
|
|
||
| def self.default_template_path(es_major_version) | ||
| default_template_name = "elasticsearch-template-es#{es_major_version}x.json" | ||
| es_major_version == "1" ? template_version = "2" : template_version = es_major_version |
Contributor
There was a problem hiding this comment.
I think you meant this
template_version = es_major_version == "1" ? "2" : es_major_versionI was a bit confused with the assignment in the ternary ops.
Contributor
|
LGTM, I havent tested with an actual ES 1.7 but I am sure it resolve #456 |
Contributor
Author
|
Thanks for fixing the ternary operator. I'm still trying to cross over my python domain knowledge into Ruby... 😮 |
Contributor
Don't worry don't tell anyone I use semicolon in ruby now because of java.. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the current default behavior anyway
fixes #456