Update v6 #34
Open
Update v6 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus-equals dog.
Dogstatsd is meant to be a drop-in replacement for Statsd, but there are some differences: 1) The "timing" metric type has been generalized into a "histogram", which is a cleaner conceptual fit for non-time values, e.g. file sizes 2) All metrics can be tagged, and Datadog will allow you to slice graphs and metric names by tag. This replaces the need to interpolate the sender hostname into the metric name. (Also, because the hostname is likely applied by the datadog agent's configuration.) This commit rewrites the output to support these features and depend on the dogstatsd-ruby gem instead of the statsd gem.
Since the dogstatsd-ruby gem authors were too lazy to rename their file from 'statsd.rb' as in the upstream statsd-ruby gem, projects like Logstash which are written in Ruby and could possibly use both have no way to differentiate between them. Luckily, Ruby lets you do whatever you want, but it's pretty gnarly. In this case, it requires a module_eval to properly namespace the Datadog Statsd class.
You can specify the same tag multiple times, e.g. we specify "role:[chef role]" for every role in the node's run list. The syntax should support this.
Upgrade to Logstash 2.0 API
…mespacing hack now that datadog properly namespaces Statsd
Feature/logstash 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Logstash 6.x version compatibility