Correct DeviceStatus Download Count and Dynamic BGData Download Limit #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. DeviceStatus.swift:
• Corrected the count parameter for device status downloads from 288 to 1, as only one record is needed. The initial value was a copy-paste error, which led to unnecessary data being downloaded.
2. BGData.swift:
• Adjusted the count parameter to dynamically calculate the limit of BG values to download. The new formula accounts for both Loop/Trio and Dexcom Share data, leading to 2 * 288 BG values per day.
• Previous hardcoded value: 1000. Two days of double data results in 1152 values.
• New dynamic value: UserDefaultsRepository.downloadDays.value * 2 * 24 * 60 / 5