-
Notifications
You must be signed in to change notification settings - Fork 1k
Temp target for Trio #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Temp target for Trio #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Collaborator
Code Review:
TestPlanned tests - report in successive comments:
Display tests
|
Collaborator
Remote Tests for Trio
Look at LoopFollow app.
Repeat more cleanly
|
marionbarker
approved these changes
Aug 5, 2024
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge to dev if @bjorkert is ready or leave here for more updates
Not a Trio user or remote user.
Limited amount of testing for that part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


New Functionality:
• Temporary Targets for Trio: Users can now set and cancel temporary targets. Future versions can include override handling for Loop.
Prerequisites: Trio and a Nightscout token with careportal and careportal roles, admin is also ok. The NS Status will indicate if your token has Read or Read+Write auth.
Refactoring:
• Alarm Tab Relocation: The Alarm tab has been moved to the settings menu and replaced by the new Remove view.
• Introducing HKQuantity and HKUnit.
• Observable User Defaults and Variables: Introduced observable user defaults and variables for better state management.
• iOS Target Update: Updated the iOS target from 13.4 to 15.6. This change should have minimal impact, as all devices running 13.4 can upgrade to 15.6.
• Build Details in Detached Mode: Capture build details now supports detached mode, allowing for builds outside of a branch or tag.