Skip to content

Auto-scroll to selected tone in picker #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Auto-scroll to selected tone in picker #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions LoopFollow/Alarm/AlarmEditing/Components/AlarmAudioSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,33 +96,39 @@ private struct TonePickerSheet: View {

var body: some View {
NavigationView {
List {
ForEach(SoundFile.allCases) { tone in
Button {
selected = tone
AlarmSound.setSoundFile(str: tone.rawValue)
AlarmSound.stop()
AlarmSound.playTest()
} label: {
HStack {
Text(tone.displayName)
if tone == selected {
Spacer()
Image(systemName: "checkmark")
.foregroundColor(.accentColor)
ScrollViewReader { proxy in
List {
ForEach(SoundFile.allCases) { tone in
Button {
selected = tone
AlarmSound.setSoundFile(str: tone.rawValue)
AlarmSound.stop()
AlarmSound.playTest()
} label: {
HStack {
Text(tone.displayName)
if tone == selected {
Spacer()
Image(systemName: "checkmark")
.foregroundColor(.accentColor)
}
}
}
.id(tone)
}
}
}
.navigationTitle("Choose Tone")
.toolbar {
ToolbarItem(placement: .confirmationAction) {
Button("Done") {
AlarmSound.stop()
dismiss()
.navigationTitle("Choose Tone")
.toolbar {
ToolbarItem(placement: .confirmationAction) {
Button("Done") {
AlarmSound.stop()
dismiss()
}
}
}
.onAppear {
proxy.scrollTo(selected, anchor: .center)
}
}
}
}
Expand Down