Skip to content

Conversation

@bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Jul 6, 2025

Fix: Improve initial setup and UI reactivity

This pull request resolves a couple of issues to create a smoother experience for first-time users. It introduces dynamic UI updates and sets more sensible defaults.

Changes

  • Dynamic Nightscout Features: When a user enters a Nightscout URL in the settings, all related UI elements (like "Information Display Settings," and "Remote Settings") now become enabled immediately without requiring an app restart. This is achieved by making the SettingsMenuView reactive to changes in the stored URL using @ObservedObject.
  • Default Remote Type: The default remoteType for new users has been changed from .nightscout to .none. This ensures that alarm settings are available as a tab by default until a user explicitly configures remote commands.

@bjorkert bjorkert requested a review from marionbarker July 6, 2025 08:16
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Not really able to do a code review - the changes seem appropriate, but not an expert.

Test

I switched between various NS URL for the test. I have:

  • Loop with no treatments
  • Loop from "real" users and test phones
  • Trio from "real" users and test phones

I confirm that the remote configuration is restored to none when switching between URL, so the Alarm icon shows up in the tool bar.

I did not notice a difference when switching between URL for dev or this branch.

@marionbarker marionbarker merged commit 6f217a8 into dev Jul 7, 2025
@marionbarker marionbarker deleted the initial-setup-improvements branch July 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants