Skip to content

Conversation

@bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Jul 7, 2025

Reset Settings Navigation on Tab Switch

Problem: When switching between tabs and returning to Settings, the navigation stack remained at the last viewed screen instead of returning to the root settings menu.

Solution:

  • Added settingsPath to the shared Observable class to manage settings navigation state
  • Updated SettingsMenuView to use the centralized navigation path
  • Reset navigation path in SettingsViewController.viewWillAppear() to ensure users always return to the root settings screen

Benefits:

  • Consistent user experience when switching tabs
  • Follows existing app architecture patterns
  • Centralized navigation state management

@bjorkert bjorkert requested a review from marionbarker July 7, 2025 19:44
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from test.

Code review

The code review looks reasonable.

Test

After building with this branch, tapping the settings icon on the toolbar takes the user to the top level settings screen.

This is the desired behavior.

@marionbarker marionbarker merged commit 4ff1a7f into dev Jul 8, 2025
@marionbarker marionbarker deleted the reset-navigation branch July 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants