Skip to content

Conversation

@Peeja
Copy link
Collaborator

@Peeja Peeja commented Aug 12, 2023

Oh My God Omg

A real demo with real xQL! For now, you'll have to have the xql repo checked out next to this one, and run pnpm build there.

The implementation of xQL still doesn't support lists, so it's not all that interesting yet, but you can still see it in action!

@Peeja Peeja requested a review from gsvarovsky August 12, 2023 14:55
Copy link
Member

@gsvarovsky gsvarovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 🎉

(Comments are just self-talk during grokking.)

Interesting effect I haven't got the bottom of yet: if you change the status in the query to some prefix of IN-PROGRESS, it still matches Buy Unicorn, unless empty, in which case it matches both todos.

Will play around more tomorrow..!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "app" part of the page is using const TODOS so the changes in this file are turning off the interactive features

Comment on lines +24 to +33
const INITIAL_QUERY = `[
{
"@context": {
"icaltzd": "http://www.w3.org/2002/12/cal/icaltzd#"
},
"icaltzd:summary": "?",
"icaltzd:status": "?"
}
]
`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of xQL still doesn't support lists

... but that doesn't affect this query because it picks out the Todos and not the todoMVCList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants