Fix main thread requirements on protocols #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
protocol-requirements
branch
from
5bf90ed to
06e2aef
Compare
madsmtm
force-pushed
the
protocol-requirements
branch
from
06e2aef to
85b23e1
Compare
madsmtm
added
bug
madsmtm
force-pushed
the
protocol-requirements
branch
2 times, most recently
from
933225f to
06e60b7
Compare
madsmtm
force-pushed
the
protocol-requirements
branch
from
06e60b7 to
9b30f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #359 I implemented marking classes as
MainThreadOnly, but a glaring omission there is that protocols were not yet marked in a similar way.This PR rectifies that by changing how the
mutabilitytraits work, allowing implementing them forProtocolObject<P>as well, which means we can now add "requirements" to protocols, such astrait MyProtocol: IsMainThreadOnly, ortrait MyProtocol: IsRetainable.We're still missing
IsRetainablebounds on pretty much everything inAppKit(and others) before we can make protocol overriding safe, but now at least the capability of adding those attributes is there.